Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AOT Feature Flag for Transactional Memory #5748

Merged
merged 2 commits into from
May 16, 2019

Conversation

dsouzai
Copy link
Contributor

@dsouzai dsouzai commented May 13, 2019

Currently, the AOT infrastructure does not check to ensure consistency in the compile and load run with regard to transactional memory support. This PR adds this check.

Depends on eclipse-omr/omr#3846

Irwin D'Souza added 2 commits May 13, 2019 17:10
Signed-off-by: Irwin D'Souza <[email protected]>
It is possible to disable TM for just a particular method. This commit
ensures that under AOT, if TM was disabled for a paticular method in
the compile run, then it should also be disabled in the load run.

Signed-off-by: Irwin D'Souza <[email protected]>
@dsouzai dsouzai added bug comp:jit depends:omr Pull request is dependent on a corresponding change in OMR comp:jit:aot labels May 13, 2019
@dsouzai
Copy link
Contributor Author

dsouzai commented May 13, 2019

@ymanton could you please review?

Copy link
Member

@ymanton ymanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straightforward enough change. LGTM.

@dsouzai dsouzai marked this pull request as ready for review May 15, 2019 15:54
@dsouzai
Copy link
Contributor Author

dsouzai commented May 15, 2019

Jenkins test sanity.functional xlinux,plinux,zlinux jdk11

@dsouzai
Copy link
Contributor Author

dsouzai commented May 15, 2019

@ymanton all tests passed, could you merge if everything looks ok?

@fjeremic fjeremic self-assigned this May 16, 2019
@fjeremic fjeremic merged commit 17f8c89 into eclipse-openj9:master May 16, 2019
@dsouzai dsouzai deleted the tmFeatureFlag branch June 25, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug comp:jit:aot comp:jit depends:omr Pull request is dependent on a corresponding change in OMR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants